[
https://issues.apache.org/jira/browse/PARQUET-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786450#comment-17786450
]
ASF GitHub Bot commented on PARQUET-2382:
-----------------------------------------
Fokko opened a new pull request, #1194:
URL: https://github.com/apache/parquet-mr/pull/1194
Make sure you have checked _all_ steps below.
For Iceberg we're adding nanosecond timestamps. During my investigation in
Parquet, I noticed that there are two ways of declaring logical types:
1. Through the deprecated `OriginalType`
2. Using the new LogicalTypeAnnotation API.
The old API does not support nano's but is still used in downstream
projects, such as Parquet, where I'm working on migrating to the new API:
https://github.com/apache/iceberg/pull/9063
However, since it was five years ago in
[PARQUET-1452](https://issues.apache.org/jira/browse/PARQUET-1452) when it was
marked as deprecated, released in Parquet 1.11.0. I would love to remove the
old API to make sure that downstream engines migrate to the new API and handle
nano's correctly.
### Jira
- [ ] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
> Remove the deprecated OriginalType
> ----------------------------------
>
> Key: PARQUET-2382
> URL: https://issues.apache.org/jira/browse/PARQUET-2382
> Project: Parquet
> Issue Type: Improvement
> Reporter: Fokko Driesprong
> Assignee: Fokko Driesprong
> Priority: Major
> Fix For: 1.14.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
