ConeyLiu commented on code in PR #1195:
URL: https://github.com/apache/parquet-mr/pull/1195#discussion_r1396740241
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/RewriteOptions.java:
##########
@@ -64,15 +72,53 @@ private RewriteOptions(Configuration conf,
this.indexCacheStrategy = indexCacheStrategy;
}
+ /**
+ * Gets the {@link Configuration} part of the rewrite options.
+ *
+ * @return the associated {@link Configuration}
+ */
public Configuration getConf() {
+ return ConfigurationUtil.createHadoopConfiguration(conf);
+ }
+
+ /**
+ * Gets the {@link ParquetConfiguration} part of the rewrite options.
+ *
+ * @return the associated {@link ParquetConfiguration}
+ */
+ public ParquetConfiguration getParquetConfiguration() {
return conf;
}
- public List<Path> getInputFiles() {
Review Comment:
I think we should not remove a public method directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
