ConeyLiu commented on code in PR #1187:
URL: https://github.com/apache/parquet-mr/pull/1187#discussion_r1396753652
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java:
##########
@@ -125,10 +125,20 @@ public class ParquetFileReader implements Closeable {
public static String PARQUET_READ_PARALLELISM =
"parquet.metadata.read.parallelism";
+ public ParquetMetricsCallback metricsCallback;
+
private final ParquetMetadataConverter converter;
private final CRC32 crc;
+
+ /**
+ * set a callback to send back metrics info
+ */
+ public synchronized void initMetrics(ParquetMetricsCallback callback) {
Review Comment:
why the `synchronized` is needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
