ConeyLiu commented on code in PR #1177:
URL: https://github.com/apache/parquet-mr/pull/1177#discussion_r1403537889
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageWriteStore.java:
##########
@@ -316,7 +346,14 @@ private int toIntWithCheck(long size) {
return (int)size;
}
- private void mergeColumnStatistics(Statistics<?> statistics) {
+ private void mergeColumnStatistics(Statistics<?> statistics,
SizeStatistics sizeStatistics) {
+ Preconditions.checkState(totalSizeStatistics != null, "Aggregate size
statistics should not be null");
Review Comment:
If the `totalSizeStatistics` is set as final. The checking here is not
needed anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
