wgtmac commented on code in PR #1177:
URL: https://github.com/apache/parquet-mr/pull/1177#discussion_r1403907724
##########
parquet-column/src/main/java/org/apache/parquet/internal/column/columnindex/OffsetIndexBuilder.java:
##########
@@ -80,11 +90,22 @@ public void add(int compressedPageSize, long rowCount) {
@Override
public void add(long offset, int compressedPageSize, long rowCount) {
}
+
+ @Override
+ public OffsetIndex build() {
Review Comment:
If I don't, `TestParquetFileWriter.testAlignmentWithPadding` and
`TestParquetFileWriter.testAlignmentWithNoPadding` will fail in the Github CI
(but not on my laptop) due to writing offset index from NoOpOffsetIndexBuilder,
which is an undefined behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
