[
https://issues.apache.org/jira/browse/PARQUET-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790129#comment-17790129
]
ASF GitHub Bot commented on PARQUET-2385:
-----------------------------------------
amousavigourabi commented on PR #1203:
URL: https://github.com/apache/parquet-mr/pull/1203#issuecomment-1828048073
> > @wgtmac , after the comments on the code style I had a quick look
through the repository and found that indentations and the such differ quite
drastically between (and even within) files. ParquetWriter has indents of four
spaces for the constructor arguments, where ParquetReader has them at 14
spaces. Would you feel anything for a more extensive `.editorconfig` and
easy-to-use linter such as spotless?
>
> Yes, I think that would be good to make the style consistent across all
files automatically.
I'll get started on expanding the `.editorconfig` for at least IntelliJ and
setting up a compatible Spotless configuration then.
> Don't initialize CodecFactory in ParquetWriter
> ----------------------------------------------
>
> Key: PARQUET-2385
> URL: https://issues.apache.org/jira/browse/PARQUET-2385
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-mr
> Reporter: Atour Mousavi Gourabi
> Priority: Major
>
> In ParquetWriter we initialize a CodecFactory, instead we should allow users
> to set their own via the builder as to provide a little more flexibility
> (analogous to PARQUET-2282).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
