zhangjiashen commented on code in PR #1219:
URL: https://github.com/apache/parquet-mr/pull/1219#discussion_r1408788644
##########
parquet-column/src/main/java/org/apache/parquet/internal/column/columnindex/ColumnIndexBuilder.java:
##########
@@ -298,24 +295,22 @@ public <T extends Comparable<T>> PrimitiveIterator.OfInt
visit(NotEq<T> notEq) {
public <T extends Comparable<T>> PrimitiveIterator.OfInt visit(In<T> in) {
Set<T> values = in.getValues();
IntSet matchingIndexesForNull = new IntOpenHashSet(); // for null
- Iterator<T> it = values.iterator();
- while(it.hasNext()) {
- T value = it.next();
- if (value == null) {
- if (nullCounts == null) {
- // Searching for nulls so if we don't have null related statistics
we have to return all pages
- return IndexIterator.all(getPageCount());
- } else {
- for (int i = 0; i < nullCounts.length; i++) {
- if (nullCounts[i] > 0) {
- matchingIndexesForNull.add(i);
+ for (T value : values) {
+ if (value == null) {
Review Comment:
Nit: Let's modify the indent spaces to 2 and ensure consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
