Fokko commented on PR #1215: URL: https://github.com/apache/parquet-mr/pull/1215#issuecomment-1833844311
@zhangjiashen Thanks for the review, appreciate it! I don't think there are any negative performance implications since the compile will just optimize it to a single concatenation. `StringBuilders` should only be used when you concatenate in a loop (fields in a schema for example). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
