Fokko commented on code in PR #1210:
URL: https://github.com/apache/parquet-mr/pull/1210#discussion_r1410732198
##########
parquet-thrift/src/main/java/org/apache/parquet/thrift/BufferedProtocolReadToWrite.java:
##########
@@ -369,7 +369,7 @@ public String toDebugString() {
ThriftField expectedField;
if ((expectedField = type.getChildById(field.id)) == null) {
handleUnrecognizedField(field, type, in);
- hasFieldsIgnored |= true;
Review Comment:
`hasFieldsIgnored |= true` equals `hasFieldsIgnored = hasFieldsIgnored ||
true` which will always return true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
