shangxinli commented on code in PR #1177:
URL: https://github.com/apache/parquet-mr/pull/1177#discussion_r1414218649
##########
parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriterBase.java:
##########
@@ -389,7 +400,14 @@ void writePage() {
this.rowsWrittenSoFar += pageRowCount;
if (DEBUG) LOG.debug("write page");
try {
- writePage(pageRowCount, valueCount, statistics, repetitionLevelColumn,
definitionLevelColumn, dataColumn);
+ writePage(
+ pageRowCount,
+ valueCount,
+ statistics,
+ sizeStatisticsBuilder.build(),
Review Comment:
Can we have the parity of lines 406 and 407? You can use a variable in line
407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
