+1 (binding). Ran build and unitests on a macbook.
Cheers, Gidon On Wed, Aug 28, 2024 at 1:32 AM Julien Le Dem <jul...@apache.org> wrote: > Hello, > Signature and checksums verified. > However, I still have issues running the build on my machine (mac os). > I have made progress but parquet-scala (compiler issue) and parquet-thrift > (one test fails) both fail right now. Unfortunately, I have limited time in > between meetings to debug this and not moving very fast. > That being said, I can also vote on the release based on the CI run. > Looking at the tag commit, it has one failed run for Vector-plugins > > https://github.com/apache/parquet-java/actions/runs/10540443775/job/29205104792 > Is there another CI run I should look at? > We need another PMC member available to add a binding vote. Any other > volunteers? > Julien > > On Mon, Aug 26, 2024 at 7:35 PM Ashish <paliwalash...@gmail.com> wrote: > > > +1 (non-binding) > > > > Ran the build, works good and all test case passes > > > > On Mon, Aug 26, 2024 at 12:51 AM Fokko Driesprong <fo...@apache.org> > > wrote: > > > > > +1 (non-binding) > > > > > > Checked the signatures and checksum, and plugged Parquet 1.14.2 RC2 > into > > > the Spark CI. <https://github.com/apache/spark/pull/47807> > > > > > > Thanks Gang for pointing out the release. In the spirit of > immutability, > > > I've created a new pre-release for RC2: > > > > > > > > > https://github.com/apache/parquet-java/releases/tag/apache-parquet-1.14.2-rc2 > > > . > > > > > > Kind regards, > > > Fokko > > > > > > > > > > > > Op ma 26 aug 2024 om 09:34 schreef Gábor Szádovszky <ga...@apache.org > >: > > > > > > > +1 (binding) > > > > > > > > Verified the checksum and signature, and the content of the tarball. > > > > Build + unit tests pass on my local Ubuntu. > > > > > > > > Cheers, > > > > Gabor > > > > > > > > Gang Wu <ust...@gmail.com> ezt írta (időpont: 2024. aug. 25., V, > > 6:51): > > > > > > > > > +1 > > > > > > > > > > Verified the artifacts by running build and test on my mac. > > > > > > > > > > BTW, should we fix the link > > > > > > > > > > > > > > > > > > > > https://github.com/apache/parquet-java/releases/tag/apache-parquet-1.14.2-rc1 > > > > > to refer to RC2? > > > > > > > > > > Best, > > > > > Gang > > > > > > > > > > On Sun, Aug 25, 2024 at 2:05 AM Fokko Driesprong <fo...@apache.org > > > > > > wrote: > > > > > > > > > > > Oops, I stopped at step 4 > > > > > > < > > https://parquet.apache.org/docs/contribution-guidelines/releasing/> > > > > and > > > > > > missed the most important one. Sorry for that! For the typo in > the > > > > tag, I > > > > > > copied the commands from the prepare-release.sh file, to avoid > > > running > > > > > all > > > > > > the tests locally. I've created a PR to make that the default > > > > > > <https://github.com/apache/parquet-java/pull/2999>. Second try: > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > I propose releasing the following RC as the official Apache > Parquet > > > > > 1.14.2 > > > > > > release. > > > > > > > > > > > > The commit ID is e7937382e7894f4780c90eb6f896c163cad4cd93 > > > > > > * This corresponds to the tag: apache-parquet-1.14.2-rc2 > > > > > > * > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/parquet-mr/tree/e7937382e7894f4780c90eb6f896c163cad4cd93 > > > > > > > > > > > > The release tarball, signature, and checksums are here: > > > > > > * > > > > > > > > > https://dist.apache.org/repos/dist/dev/parquet/apache-parquet-1.14.2-rc2 > > > > > > > > > > > > You can find the KEYS file here: > > > > > > * https://downloads.apache.org/parquet/KEYS > > > > > > > > > > > > You can find the changelog here: > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/parquet-java/releases/tag/apache-parquet-1.14.2- > > > > > > rc2 > > > > > > < > > > > > > > > > > > > > > > https://github.com/apache/parquet-java/releases/tag/apache-parquet-1.14.2-rc2 > > > > > > > > > > > > > > > > > > Binary artifacts are staged in Nexus here: > > > > > > * > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheparquet-1059/ > > > > > > > > > > > > Please download, verify, and test. > > > > > > > > > > > > Please vote in the next 72 hours. > > > > > > > > > > > > [ ] +1 Release this as Apache Parquet 1.14.2 > > > > > > [ ] +0 > > > > > > [ ] -1 Do not release this because... > > > > > > > > > > > > Kind regards, > > > > > > Fokko > > > > > > > > > > > > Op do 22 aug 2024 om 00:44 schreef Julien Le Dem < > > jul...@apache.org > > > >: > > > > > > > > > > > > > Seconding this, > > > > > > > Thank you for shepherding the release, > > > > > > > Please let us know when you get a chance to push the tarball > > again > > > > and > > > > > > I'll > > > > > > > resume testing. > > > > > > > Best > > > > > > > > > > > > > > On Wed, Aug 21, 2024 at 3:14 AM Gábor Szádovszky < > > ga...@apache.org > > > > > > > > > > wrote: > > > > > > > > > > > > > > > Thanks a lot, Fokko for taking care of the release. > > > > > > > > > > > > > > > > * There is a typo in the tag name therefore it is not > according > > > to > > > > > your > > > > > > > > previous email: apache-parquet-1.14.2rc2 (note the missing > `-` > > > > before > > > > > > > > "rc2") > > > > > > > > * Also, the tarball link does not exist. (rc1 is the last one > > for > > > > > > 1.14.2) > > > > > > > > * You're referencing the changelog with a simple tag (which > is > > > not > > > > > > > working > > > > > > > > due to the typo). Shouldn't the link reference the CHANGES.md > > > file > > > > > > > > directly? But that one does not contain 1.14.2 changes. > > > > > > > > > > > > > > > > I'm not giving a -1 since these issues might be able to be > > > > corrected > > > > > > > > without rc3. > > > > > > > > > > > > > > > > Cheers, > > > > > > > > Gabor > > > > > > > > > > > > > > > > Fokko Driesprong <fo...@apache.org> ezt írta (időpont: 2024. > > > aug. > > > > > 21., > > > > > > > > Sze, > > > > > > > > 11:08): > > > > > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > > > > > I propose the following RC to be released as the official > > > Apache > > > > > > > Parquet > > > > > > > > > 1.14.2 release. > > > > > > > > > > > > > > > > > > The commit ID is e7937382e7894f4780c90eb6f896c163cad4cd93 > > > > > > > > > * This corresponds to the tag: apache-parquet-1.14.2-rc2 > > > > > > > > > * > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/parquet-mr/tree/e7937382e7894f4780c90eb6f896c163cad4cd93 > > > > > > > > > > > > > > > > > > The release tarball, signature, and checksums are here: > > > > > > > > > * > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/parquet/apache-parquet-1.14.2-rc2 > > > > > > > > > > > > > > > > > > You can find the KEYS file here: > > > > > > > > > * https://downloads.apache.org/parquet/KEYS > > > > > > > > > > > > > > > > > > You can find the changelog here: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/parquet-java/releases/tag/apache-parquet-1.14.2-rc2 > > > > > > > > > > > > > > > > > > Binary artifacts are staged in Nexus here: > > > > > > > > > * > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheparquet-1059/ > > > > > > > > > > > > > > > > > > Please download, verify, and test. > > > > > > > > > > > > > > > > > > Please vote in the next 72 hours. > > > > > > > > > > > > > > > > > > [ ] +1 Release this as Apache Parquet 1.14.2 > > > > > > > > > [ ] +0 > > > > > > > > > [ ] -1 Do not release this because... > > > > > > > > > > > > > > > > > > Kind regards, > > > > > > > > > Fokko > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > thanks > > ashish > > >
