I was closing down my old PR to bump Scala, and created a new one to drop the module <https://github.com/apache/parquet-java/pull/3063>.
Gábor, I forgot about the deprecated pattern that we applied in the past <https://mvnrepository.com/artifact/org.apache.parquet/parquet-cascading-deprecated>. I would be in favor of just removing them. You could still use an older version of the scala module since it only uses a few Java APIs and those I expect to be very stable. Kind regards, Fokko Op vr 15 nov 2024 om 11:01 schreef Cheng Pan <pan3...@gmail.com>: > Given there is no evidence that users are still using it, and no > developers object, I think we can remove it. > > I saw Fokko just opened a PR[1], thanks for doing that! > > [1] https://github.com/apache/parquet-java/pull/3063 > > Thanks, > Cheng Pan > > > > > On Nov 8, 2024, at 16:20, Gábor Szádovszky <ga...@apache.org> wrote: > > > > What we did with other modules to be retired in the past is we renamed > them > > (as of both maven artifacts and directory naming) to `..._deprecated`. > This > > way anyone might use it can still do it for another minor release, and be > > warned that it'll be removed. In the next minor release we actually > removed > > these modules. > > I do not have a strong opinion on this one though. Since you all think > that > > it is not used, I'm fine with simply removing it. > > > > Julien Le Dem <jul...@apache.org> ezt írta (időpont: 2024. nov. 8., P, > > 0:51): > > > >> The code hasn't changed at all since 2015 and is very small. > >> Since there is an easy workaround for anyone who might be using it (copy > >> the one class that has no other dependency) the trade off feels clear. > >> I am in favor of removing it. > >> > >> > >> > >> On Thu, Nov 7, 2024 at 11:56 AM Fokko Driesprong <fo...@apache.org> > wrote: > >> > >>> Hey Cheng, > >>> > >>> As mentioned on the PR, there is not much evidence that anyone is using > >> the > >>> parquet-scala module: > >>> https://mvnrepository.com/artifact/org.apache.parquet/parquet-scala. > >> Scala > >>> 2.12 is EOL while there are still maintenance releases > >>> <https://endoflife.date/scala> being done, and I don't see much > interest > >>> in > >>> Scala 2.13. I would be in favor of retiring the module since there > >>> haven't been any contributions > >>> <https://github.com/apache/parquet-java/commits/master/parquet-scala> > in > >>> the last few major releases. This will also allow us to remove the > Scala > >>> build, making the project quite a bit leaner. > >>> > >>> Curious to learn what others think! > >>> > >>> Kind regards, > >>> Fokko > >>> > >>> Op do 7 nov 2024 om 10:36 schreef Cheng Pan <pan3...@gmail.com>: > >>> > >>>> Hi parquet developers, > >>>> > >>>> I’m wondering if anyone consumes the `parquet-scala` dependency in > your > >>>> project, the module exists for a long time but with rare code > >> change[1], > >>>> all recently commit applied to this module is just dependency > >> upgrading / > >>>> build fixing [2]. > >>>> > >>>> I suggest retiring the parquet-scala module, or even dropping it > >>> directly. > >>>> > >>>> The module only contains one `Dsl` class[3], which is thin wrapper of > >> the > >>>> Java API, users are easy to copy and embed it if we drop the > >>> parquet-scala > >>>> module. Additionally, it's rare to publish a scala lib that only > >>> supports a > >>>> single scala binary version, most scala libs support 2~3 scala binary > >>>> versions in each version. > >>>> > >>>> [1] > >> https://github.com/apache/parquet-java/commits/master/parquet-scala > >>>> [2] https://github.com/apache/parquet-java/pull/3044 > >>>> [3] > >>>> > >>> > >> > https://github.com/apache/parquet-java/blob/master/parquet-scala/src/main/scala/org/apache/parquet/filter2/dsl/Dsl.scala > >>>> > >>>> Thanks, > >>>> Cheng Pan > >>>> > >>>> > >>>> > >>>> > >>> > >> > >
