Let's close this RC, and let me prepare a new one. Thanks everyone for the quick follow-up!
Kind regards, Fokko Op do 28 nov 2024 om 15:10 schreef Fokko Driesprong <fo...@apache.org>: > Hey everyone, > > I also tracked down the issue for Spark. It was caused when converting the > ParquetMetadata to JSON for logging purposes. I've raised an issue > <https://github.com/apache/parquet-java/issues/3086> and created a PR > <https://github.com/apache/parquet-java/pull/3087>. PTAL and happy > Thanksgiving! > > Kind regards, > Fokko > > Op di 26 nov 2024 om 22:34 schreef Fokko Driesprong <fo...@apache.org>: > >> Thanks Gábor for the quick review. >> >> I've tested the RC1 against Iceberg, and that one uncovered an issue with >> the Jackson shading, JDK22 was missing from the list. I've raised a PR >> to fix that <https://github.com/apache/parquet-java/pull/3081>. Also a >> PR to lower the version of buildnumber-maven-plugin >> <https://github.com/apache/parquet-java/pull/3082> to 3.2.0. >> >> There is also an issue on the Spark side that needs a bit more attention >> <https://github.com/apache/spark/pull/48970>. Will let y'all know when I >> find the issue, but it looks like we're going to need another RC. >> >> Kind regards, >> Fokko >> >> Op di 26 nov 2024 om 17:06 schreef Gábor Szádovszky <ga...@apache.org>: >> >>> Thanks a lot for working on the release, Fokko! >>> >>> I've checked the tarball content, signature and checksum, build, and unit >>> tests. All works fine. >>> >>> I have only one issue: The buildnumber-maven-plugin 3.2.1 fails in case >>> the >>> build is not invoked in a git repo. It makes it unable to build the >>> tarball. Downgrading to 3.2.0 solves the issue. I don't think it should >>> be >>> a show stopper for this release, but it makes sense to fix on the branch >>> and include in the next potential rc (if any). >>> >>> +1 (binding) >>> >>> Cheers, >>> Gabor >>> >>> >>> Gang Wu <ust...@gmail.com> ezt írta (időpont: 2024. nov. 26., K, 16:37): >>> >>> > +1 >>> > >>> > Thanks for the quick fix! >>> > >>> > On Tue, Nov 26, 2024 at 11:32 PM Fokko Driesprong <fo...@apache.org> >>> > wrote: >>> > >>> > > Hey Gang, >>> > > >>> > > Thanks for the quick response. Good one, I was on the wrong branch. >>> The >>> > > branch is now there: >>> > > https://github.com/apache/parquet-java/commits/parquet-1.15.x >>> > > >>> > > Good catch on the parquet-mr. I've checked all the links before >>> sending >>> > out >>> > > the mail, and luckily there is still a redirect. I've copied the link >>> > from >>> > > the template and it be good to get the template fixed: >>> > > https://github.com/apache/parquet-site/pull/89 >>> > > >>> > > Kind regards, >>> > > Fokko >>> > > >>> > > >>> > > >>> > > Op di 26 nov 2024 om 16:12 schreef Gang Wu <ust...@gmail.com>: >>> > > >>> > > > Thanks Fokko for driving this! >>> > > > >>> > > > Do we need to cut a 1.15.x branch before preparing the RCs? >>> > > > >>> > > > BTW, I think it would be better to use parquet-java instead of >>> > parquet-mr >>> > > > in the first URL. >>> > > > >>> > > > Best, >>> > > > Gang >>> > > > >>> > > > On Tue, Nov 26, 2024 at 5:15 PM Fokko Driesprong <fo...@apache.org >>> > >>> > > wrote: >>> > > > >>> > > > > Hi everyone, >>> > > > > >>> > > > > I propose releasing the following RC as the official Apache >>> Parquet >>> > > > 1.15.0 >>> > > > > release. >>> > > > > >>> > > > > The commit SHA is 84ba54a3a618e293309885042cb289fe2f7b9f00 >>> > > > > * This corresponds to the tag: apache-parquet-1.15.0-rc1 >>> > > > > * >>> > > > > >>> > > > > >>> > > > >>> > > >>> > >>> https://github.com/apache/parquet-mr/tree/84ba54a3a618e293309885042cb289fe2f7b9f00 >>> > > > > >>> > > > > The release tarball, signature, and checksums are here: >>> > > > > * >>> > > > > >>> > > > >>> > > >>> > >>> https://dist.apache.org/repos/dist/dev/parquet/apache-parquet-1.15.0-rc1/ >>> > > > > >>> > > > > You can find the KEYS file here: >>> > > > > * https://downloads.apache.org/parquet/KEYS >>> > > > > >>> > > > > You can find the changelog here: >>> > > > > >>> > > > > >>> > > > >>> > > >>> > >>> https://github.com/apache/parquet-java/releases/tag/apache-parquet-1.15.0-rc1 >>> > > > > >>> > > > > Binary artifacts are staged in Nexus here: >>> > > > > * >>> > > > > >>> > > > >>> > > >>> > >>> https://repository.apache.org/content/repositories/orgapacheparquet-1066/ >>> > > > > >>> > > > > Please download, verify, and test. Please vote in the next 72 >>> hours. >>> > > > > >>> > > > > [ ] +1 Release this as Apache Parquet 1.15.0 >>> > > > > [ ] +0 >>> > > > > [ ] -1 Do not release this because... >>> > > > > >>> > > > > Kind regards, >>> > > > > Fokko >>> > > > > >>> > > > >>> > > >>> > >>> >>