[jira] [Commented] (PARQUET-178) META-INF for slf4j should not be in parquet-format jar

[koert kuipers (JIRA)]

    [ 
https://issues.apache.org/jira/browse/PARQUET-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307759#comment-14307759
 ] 

koert kuipers commented on PARQUET-178:
---------------------------------------

the slf4j classes themselves are shaded, no? so they dont conflict?

{noformat}
$ jar tf lib_managed/parquet-format-2.2.0-rc1.jar  | grep slf
parquet/org/slf4j/
parquet/org/slf4j/helpers/
parquet/org/slf4j/helpers/BasicMarker.class
parquet/org/slf4j/helpers/BasicMarkerFactory.class
parquet/org/slf4j/helpers/BasicMDCAdapter.class
parquet/org/slf4j/helpers/FormattingTuple.class
parquet/org/slf4j/helpers/MarkerIgnoringBase.class
parquet/org/slf4j/helpers/MessageFormatter.class
parquet/org/slf4j/helpers/NamedLoggerBase.class
parquet/org/slf4j/helpers/NOPLogger.class
parquet/org/slf4j/helpers/NOPLoggerFactory.class
parquet/org/slf4j/helpers/NOPMDCAdapter.class
parquet/org/slf4j/helpers/SubstituteLoggerFactory.class
parquet/org/slf4j/helpers/Util.class
parquet/org/slf4j/ILoggerFactory.class
parquet/org/slf4j/IMarkerFactory.class
parquet/org/slf4j/Logger.class
parquet/org/slf4j/LoggerFactory.class
parquet/org/slf4j/Marker.class
parquet/org/slf4j/MarkerFactory.class
parquet/org/slf4j/MDC.class
parquet/org/slf4j/spi/
parquet/org/slf4j/spi/LocationAwareLogger.class
parquet/org/slf4j/spi/LoggerFactoryBinder.class
parquet/org/slf4j/spi/MarkerFactoryBinder.class
parquet/org/slf4j/spi/MDCAdapter.class
META-INF/maven/org.slf4j/
META-INF/maven/org.slf4j/slf4j-api/
META-INF/maven/org.slf4j/slf4j-api/pom.xml
META-INF/maven/org.slf4j/slf4j-api/pom.properties
{noformat}

> META-INF for slf4j should not be in parquet-format jar
> ------------------------------------------------------
>
>                 Key: PARQUET-178
>                 URL: https://issues.apache.org/jira/browse/PARQUET-178
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-format
>    Affects Versions: 1.6.0rc2
>            Reporter: koert kuipers
>            Priority: Minor
>
> {noformat}
> $ jar tf parquet-format-2.2.0-rc1.jar  | grep org\\.slf
> META-INF/maven/org.slf4j/
> META-INF/maven/org.slf4j/slf4j-api/
> META-INF/maven/org.slf4j/slf4j-api/pom.xml
> META-INF/maven/org.slf4j/slf4j-api/pom.properties
> {noformat}
> It is not clear to me why these are here. I suspect they should not be.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)