Hi Jeremias,Eric, While nothing has been commited of my work and I still update my sources to have an up to date version. It is not a problem to create a branch now and push all in it... well, the only problem will be my knowledge of svn ;-)
I cannot make different patches as proposed by Eric, because it is a deep refactor. Today, my local version is stable and all unitary tests are OK. Isartor tests are still all OK. Who can help to create a branch ? Do I need authorization do create one ? Is this command enough : svn copy https://svn.apache.org/repos/asf/pdfbox/trunk/ https://svn.apache.org/repos/asf/pdfbox/branches/1.7.1-newxmpbox -m "branch for refactoring of xmpbox" Thanks for your help ! Guillaume On Thu, Jul 26, 2012 at 6:43 PM, Jeremias Maerki <[email protected]> wrote: > Salut Guillaume, > I'm not a fan of big bulk commits if they can be broken down. I don't > know over how much time you've worked on this but I'm wondering if it > hadn't been better if you had created a temporary branch for this larger > task. When the refactoring is done and everything is stable again it can > be merged back into trunk (with one commit but interested parties would > then be able to digest the overall changes in smaller bits by studying > the branch's commit log). > > > Jeremias Maerki > > > On 25.07.2012 20:53:00 Guillaume Bailleul wrote: >> Hi, >> >> I worked on xmpbox and made many modifications : >> * reduced code duplication >> * implemented missing structured types >> * implemented missing namespaces >> * increased code coverage >> * simplified some unnecessary complex parts >> >> My patch is about 620kb long. It only have few impact on preflight and >> no impact on other modules. >> >> So I don't know if I commit it like a simple patch or if there is an >> other way to do it. Does someone have the answer to that question ? >> >> Thanks for your help, >> >> Guillaume >
