[
https://issues.apache.org/jira/browse/PDFBOX-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907548#comment-13907548
]
John Hewson commented on PDFBOX-1833:
-------------------------------------
This patch does not follow PDFBox [coding
conventions|http://pdfbox.apache.org/codingconventions.html]. In particular, we
wrap lines longer than 100 characters. We also follow [Sun's guidelines for
JavaDoc|http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html],
which means we write JavaDoc like this:
{code}
/**
* Sets the document for this stream.
* @param doc the current document
*/
{code}
We don't do this:
{code}
/**
* Set the document for this stream.
*
* @param doc
* The current document.
*
* @param doc
* The current document.
*/
{code}
Also, please don't make any code changes if you're making major formatting
changes, as it's too hard too see from the diff what is going on. Split these
into different patches (one can be dependent on the other).
> BaseParser tidy up
> ------------------
>
> Key: PDFBOX-1833
> URL: https://issues.apache.org/jira/browse/PDFBOX-1833
> Project: PDFBox
> Issue Type: Improvement
> Components: Parsing
> Reporter: Jens Kapitza
> Priority: Minor
> Attachments: baseparser.patch, baseparserv2.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> Tidy up logic (should not change the parsing result)
> Character.isWhitespace(c) is the only point wich may have site effects (but i
> assume there is no File-Seperator in parseCOSHexString)
> so this should pass as it passes befor.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
