[
https://issues.apache.org/jira/browse/PDFBOX-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13916343#comment-13916343
]
John Hewson commented on PDFBOX-1833:
-------------------------------------
Your new patch looks good.
{quote}
in one file there are multiple conventions
{quote}
The original code was written using a convention which has since been
abandoned. The old files are slowly being cleaned up. BaseParser is one of the
files which still needs a clean-up, but it is probably going to just be
replaced instead.
{quote}
is there a big reformatting patch?
{quote}
No, because it's not just formatting: the original code used some programming
constructs which we'd rather remove, and the "old style" formatting is
currently the only way to keep track of which files have been cleaned up and
which haven't. Each file needs to be modernised by hand, with code formatting
being just one part of that.
> BaseParser tidy up
> ------------------
>
> Key: PDFBOX-1833
> URL: https://issues.apache.org/jira/browse/PDFBOX-1833
> Project: PDFBox
> Issue Type: Improvement
> Components: Parsing
> Reporter: Jens Kapitza
> Priority: Minor
> Attachments: baseparser.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> Tidy up logic (should not change the parsing result)
> Character.isWhitespace(c) is the only point wich may have site effects (but i
> assume there is no File-Seperator in parseCOSHexString)
> so this should pass as it passes befor.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
