[
https://issues.apache.org/jira/browse/PDFBOX-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923711#comment-13923711
]
Maruan Sahyoun commented on PDFBOX-1963:
----------------------------------------
John, I do know about CTR. But as you found out the change affects others. So
in order to be defensive instead of changing a known and used API you could
have introduced a new method with the behavior you intend mark the old one
deprecated and all are fine. Now you have done differently - which you can do -
but you somehow ignore the feedback and that’s not CTR!
The feedback is constructive and I do suggest that you take that into account.
Saying a „ … debate doesn’t matter … „ is not an argument.
> PDFImageWriter doesn't make use of PDFStreamEngine
> --------------------------------------------------
>
> Key: PDFBOX-1963
> URL: https://issues.apache.org/jira/browse/PDFBOX-1963
> Project: PDFBox
> Issue Type: Improvement
> Components: Utilities
> Affects Versions: 2.0.0
> Reporter: John Hewson
> Assignee: John Hewson
> Fix For: 2.0.0
>
>
> PDFImageWriter is a subclass of PDFStreamEngine, however it never uses any of
> its functionality, the writeImage methods could be marked as static and
> behave in the same manner.
> The relationship between PDFImageWriter, RenderUtil, and ImageIOUtil no
> longer matches its historical origins and needs to be refactored.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
