[
https://issues.apache.org/jira/browse/PDFBOX-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923718#comment-13923718
]
Tilman Hausherr edited comment on PDFBOX-1963 at 3/7/14 10:22 AM:
------------------------------------------------------------------
An ideal method would be
{code}
renderImage(PDPage pdPage, int imageType, int resolution)
{code}
all the other ones you introduced can be kept for convenience and can lead to
this one, alternatively have the above for convenience / compatibility and have
{code}
renderImage(PDPage pdPage, int imageType, float scale)
{code}
as the central one and all the other ones for convenience / compatibility.
Btw don't forget that its not just the users here, its also fellow apache
projects that use PDFBOX.
was (Author: tilman):
An ideal method would be
{code}
renderImage(PDPage page, int imageType, int resolution)
{code}
all the other ones you introduced can be kept for convenience and can lead to
this one, alternatively have the above for convenience / compatibility and have
{code}
renderImage(PDPage page, int imageType, float scale)
{code}
as the central one.
Btw don't forget that its not just the users here, its also fellow apache
projects that use PDFBOX.
> PDFImageWriter doesn't make use of PDFStreamEngine
> --------------------------------------------------
>
> Key: PDFBOX-1963
> URL: https://issues.apache.org/jira/browse/PDFBOX-1963
> Project: PDFBox
> Issue Type: Improvement
> Components: Utilities
> Affects Versions: 2.0.0
> Reporter: John Hewson
> Assignee: John Hewson
> Fix For: 2.0.0
>
>
> PDFImageWriter is a subclass of PDFStreamEngine, however it never uses any of
> its functionality, the writeImage methods could be marked as static and
> behave in the same manner.
> The relationship between PDFImageWriter, RenderUtil, and ImageIOUtil no
> longer matches its historical origins and needs to be refactored.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
