[ 
https://issues.apache.org/jira/browse/PDFBOX-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923630#comment-13923630
 ] 

Tilman Hausherr edited comment on PDFBOX-1963 at 3/7/14 11:41 AM:
------------------------------------------------------------------

You also modified another test, although one that isn't used actively except by 
me: TestPDFToImage. Previously it was testing at 96 dpi or screen resolution 
(the template images are 96 dpi), now it is testing at scale 1, which is 
currently 72 dpi which is the new default. 

The previous default of RenderUtil was 144 dpi. -This should also be put back.-

A default of 72 dpi will provide a poor user experience. Historically, its the 
reason I choose PDFBOX over a competing open source product a few years ago, 
because I only got tiny images with the other product and it wasn't possible to 
set the resolution in that other product (or I didn't find it in the API of 
that other product).


was (Author: tilman):
You also modified another test, although one that isn't used actively except by 
me: TestPDFToImage. Previously it was testing at 96 dpi or screen resolution 
(the template images are 96 dpi), now it is testing at scale 1, which is 
currently 72 dpi which is the new default. 

The previous default of RenderUtil was 144 dpi. This should also be put back.

A default of 72 dpi will provide a poor user experience. Historically, its the 
reason I choose PDFBOX over a competing open source product a few years ago, 
because I only got tiny images with the other product and it wasn't possible to 
set the resolution in that other product (or I didn't find it in the API of 
that other product).

> PDFImageWriter doesn't make use of PDFStreamEngine
> --------------------------------------------------
>
>                 Key: PDFBOX-1963
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1963
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 2.0.0
>            Reporter: John Hewson
>            Assignee: John Hewson
>             Fix For: 2.0.0
>
>
> PDFImageWriter is a subclass of PDFStreamEngine, however it never uses any of 
> its functionality, the writeImage methods could be marked as static and 
> behave in the same manner.
> The relationship between PDFImageWriter, RenderUtil, and ImageIOUtil no 
> longer matches its historical origins and needs to be refactored.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to