[
https://issues.apache.org/jira/browse/PDFBOX-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924692#comment-13924692
]
John Hewson edited comment on PDFBOX-1966 at 3/8/14 3:19 AM:
-------------------------------------------------------------
I just realised: toTilingPaint and toShadingPaint should be private. I've just
fixed this in revision 1575475. This actually reinforces my point about
encapsulation: toShadingPaint would have to be public if moved to PDShading
which would expose the internal implementation details of AWT Paint to the
public API, thus breaking encapsulation.
was (Author: jahewson):
Aha, actually, toTilingPaint and toShadingPaint should be private. I've just
fixed this in revision 1575475. This actually reinforcs my point about
encapsulation: toShadingPaint would have to be public if moved to PDShading
which would expose the internal implementation details of AWT Paint to the
public API, thus breaking encapsulation.
> Type 1, 4 and 5 shadings for shFill()
> -------------------------------------
>
> Key: PDFBOX-1966
> URL: https://issues.apache.org/jira/browse/PDFBOX-1966
> Project: PDFBox
> Issue Type: Bug
> Components: Rendering
> Affects Versions: 1.8.4, 2.0.0
> Reporter: Tilman Hausherr
> Assignee: Tilman Hausherr
> Priority: Minor
> Labels: shading, shadingpattern
> Fix For: 1.8.5, 2.0.0
>
> Attachments: asy-functionshading.pdf, asy-functionshading.pdf-1.tif,
> hsv-shading.pdf, hsv-shading.pdf-1.png
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> I found two images that didn't render properly. The reason is that the
> appropriate code was missing in shFill() (the code is there for axial and
> radial shading). I will fix this.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
