[
https://issues.apache.org/jira/browse/PDFBOX-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924752#comment-13924752
]
Tilman Hausherr edited comment on PDFBOX-1966 at 3/8/14 1:26 PM:
-----------------------------------------------------------------
I also thought about creating a pattern dictionary and filling it, but at the
end it looked like too much code to create just to get rid of the double code.
What we need is some single method somewhere that takes a pattern, a matrix and
a page height as an input and returns the appropriate paint. Maybe in a
ShadingPaintFactory?
I'm also for thinking about how to get rid of that switch. In a perfect world,
a derived class would "do the right thing" just because it is derived.
was (Author: tilman):
I also thought about creating a pattern dictionary and filling it, but at the
end it looked like too much code to create just to get rid of the double code.
What we need is some single method somewhere that takes a pattern, a matrix and
a page height as an input and returns the appropriate paint. Maybe in a
ShadingPaintFactory?
> Type 1, 4 and 5 shadings for shFill()
> -------------------------------------
>
> Key: PDFBOX-1966
> URL: https://issues.apache.org/jira/browse/PDFBOX-1966
> Project: PDFBox
> Issue Type: Bug
> Components: Rendering
> Affects Versions: 1.8.4, 2.0.0
> Reporter: Tilman Hausherr
> Assignee: Tilman Hausherr
> Priority: Minor
> Labels: shading, shadingpattern
> Fix For: 1.8.5, 2.0.0
>
> Attachments: asy-functionshading.pdf, asy-functionshading.pdf-1.tif,
> hsv-shading.pdf, hsv-shading.pdf-1.png
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> I found two images that didn't render properly. The reason is that the
> appropriate code was missing in shFill() (the code is there for axial and
> radial shading). I will fix this.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
