[ 
https://issues.apache.org/jira/browse/PDFBOX-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906440#comment-14906440
 ] 

Maruan Sahyoun commented on PDFBOX-2252:
----------------------------------------

[~AndreasMeier] sorry for all the question given the fact you already put so 
much effort into the patch. Would it be possible to 

- generate a set of sample files and unit test to confirm the current issue
- verify how that has been resolved by the patch

I would like to put in some time to verify if the java classes could be used as 
a replacement of some of the custom code. E.g. {{Character.isMirrored()}} might 
be used instead of the custom code/pattern (we'd still need to use the 
BidiMirroring properties as there is no method to get the corresponding char in 
the standard classes). That might be done in a second step but there the unit 
tests are important in order to make sure nothing breaks.


> PDFTextStripper has problem with documents with mixed language directions
> -------------------------------------------------------------------------
>
>                 Key: PDFBOX-2252
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2252
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Text extraction
>    Affects Versions: 1.8.6, 2.0.0
>            Reporter: Amir
>            Assignee: Maruan Sahyoun
>            Priority: Critical
>             Fix For: 2.1.0
>
>         Attachments: BidiMirroring.txt, PDFTextStripper.java.patch, 
> PDFTextStripper.java.patch, atest.pdf, overlap.jpg, test.pdf, 
> wikipedia_dl_lyric_test.pdf
>
>
> When the input document of PDFTextStripper is a combination of right-to-left 
> and left-to-right languages, the output characters of one language is 
> reversed. 
> A sample bilingual pdf document is attached.
> PDFTextStripper has a variable "isRtlDominant" in "writePage" function, which 
> is defined as follows:     boolean isRtlDominant = rtlCount > ltrCount;
> This class clearly count the number of rtl characters and decide if the whole 
> content should be revered or not. It's not true, it must operate on each 
> word, not the whole document.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to