Tilman Hausherr commented on PDFBOX-2852:

I disagree with dumping COSArrayList everywhere (although I'm aware that the 
current situation is weird) because

- we haven't researched why this was introduced in the first place
- it is needed for annotations, replacing it with a List<PDAnnotation> will 
break signing already signed PDFs, because signing expects references / direct 
objects to stay
- it will require a lot of user support

> Improve code quality (2)
> ------------------------
>                 Key: PDFBOX-2852
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2852
>             Project: PDFBox
>          Issue Type: Task
>    Affects Versions: 2.0.0
>            Reporter: Tilman Hausherr
>         Attachments: PDNameTreeNode.java.patch, XMPSchema.java.patch, 
> explicit_array_creation.patch, fix_javadoc.patch, foreach.patch, 
> noarray.patch, semicolon.patch, stringbuilder.patch, 
> unnecessary_type_casting.patch, unused_imports.patch, usestatic.patch, 
> winansiencoding.patch, winansiencoding2.patch
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2576, which was getting too long.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to