Maruan Sahyoun commented on PDFBOX-2852:

well - moving forward what's the proposed preference - backing the List by 
CosArrayList or not so we have a pattern for new functionality. And maybe we 
can reduce the number of areas where this is not followed although some might 
stay with the current behavior.

it is needed for annotations, replacing it with a List<PDAnnotation> will break 
signing already signed PDFs, because signing expects references / direct 
objects to stay

I don't understand this one. If we sign an already signed PDF don't we write 
the changes only doing an incremental save so the old annotations stay as they 

> Improve code quality (2)
> ------------------------
>                 Key: PDFBOX-2852
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2852
>             Project: PDFBox
>          Issue Type: Task
>    Affects Versions: 2.0.0
>            Reporter: Tilman Hausherr
>         Attachments: PDNameTreeNode.java.patch, XMPSchema.java.patch, 
> explicit_array_creation.patch, fix_javadoc.patch, foreach.patch, 
> noarray.patch, semicolon.patch, stringbuilder.patch, 
> unnecessary_type_casting.patch, unused_imports.patch, usestatic.patch, 
> winansiencoding.patch, winansiencoding2.patch
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-2576, which was getting too long.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to