I won't have results immediately. :) -----Original Message----- From: Tilman Hausherr [mailto:[email protected]] Sent: Tuesday, May 9, 2017 4:13 PM To: [email protected] Subject: Re: 2.0.6 release ?
Am 09.05.2017 um 22:03 schrieb Allison, Timothy B.: > UGH. I'm so wrong. I accidentally had a 2.0.4.jar in my app/target... > > <face_palm/> > > Off we go? Yes! However it's 10pm here, so I won't be able to react to the results immediately. Tilman > > > -----Original Message----- > From: Tilman Hausherr [mailto:[email protected]] > Sent: Tuesday, May 9, 2017 3:49 PM > To: [email protected] > Subject: Re: 2.0.6 release ? > > You caught me... I haven't checked these yet. > > But I did now, with > MD6X34Z6CODIJODXTOH5E6WJ7VUUPITO.pdf > 3TE3TRHZVL2ZJGUUASZEWNOY6DXRTTEK.ashx > IDEJP3MH4FCZNNTWQDMZ6TD2MOIPAYZ7.ashx > but they don't throw an NPE anymore now. > > Oops... I see I have that check you mention in my code, it has been there for > months and I forgot to make an issue. But after removing it, it still works > with the three files... so the question is, can this parameter ever be null, > or not? > > Tilman > > Am 09.05.2017 um 21:34 schrieb Allison, Timothy B.: >> Should we return false if the node is null in PDPageTree#isPageTreeNode (66 >> new NPE exceptions)? Has this been fixed, or would that cause unintended >> problems? >> >> /** >> * Returns true if the node is a page tree node (i.e. and >> intermediate). >> */ >> private boolean isPageTreeNode(COSDictionary node ) >> { >> // some files such as PDFBOX-2250-229205.pdf don't have Pages set >> as the Type, so we have >> // to check for the presence of Kids too >> return node.getCOSName(COSName.TYPE) == COSName.PAGES || >> node.containsKey(COSName.KIDS); >> } >> >> -----Original Message----- >> From: Tilman Hausherr [mailto:[email protected]] >> Sent: Tuesday, May 9, 2017 3:20 PM >> To: [email protected] >> Subject: Re: 2.0.6 release ? >> >> Am 09.05.2017 um 21:01 schrieb Allison, Timothy B.: >>>> I've fixed all remaining regression tickets (in the end it was >>>> exactly 1) >>> Great! Thank you! >>> >>> Let me know when I should kick off another eval. >> Yes, please do. >> >> Thanks >> >> Tilman >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] For >> additional commands, e-mail: [email protected] >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] For >> additional commands, e-mail: [email protected] >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] For > additional commands, e-mail: [email protected] > > > B KKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKCB > [ X ܚX KK[XZ[ > ] ][ X ܚX P > \X K ܙ B ܈Y][ۘ[ [X[ K[XZ[ > ] Z[ > \X K ܙ B B > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] For > additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
