[
https://issues.apache.org/jira/browse/PDFBOX-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079082#comment-16079082
]
Tilman Hausherr edited comment on PDFBOX-3854 at 7/8/17 11:11 AM:
------------------------------------------------------------------
Some more benchmark results:
- on a new fast PC with 8 physical (16 HT) cores the improvement (copying every
single pixel) make the benchmark almost 3x as fast than the trunk: from 23717
secs to 8559 secs
- using the "long" version of {{setRGB()}} brings no improvement
So I'll commit that (copying every single pixel) with a comment.
was (Author: tilman):
Some more benchmark results:
- on a new fast PC with 8 physical (16 HT) cores the improvement (copying every
single pixel) make it almost 3x as fast than the trunk: from 23717 secs to 8559
secs
- using the "long" version of {{setRGB()}} brings no improvement
So I'll commit that with a comment.
> PDDeviceRGB.toRGBImage does not return a RGB-Typed-Image
> --------------------------------------------------------
>
> Key: PDFBOX-3854
> URL: https://issues.apache.org/jira/browse/PDFBOX-3854
> Project: PDFBox
> Issue Type: Bug
> Components: PDModel, Rendering
> Affects Versions: 2.0.6
> Reporter: Yannick Haser
> Labels: optimization
> Attachments: rgbImageExample0.pdf, rgbImageSecondExample.pdf,
> Starter2.java, Starter.java
>
>
> While converting a PDPage to a BufferedImage (using the PDFRenderer)
> Images-Resources located in the PDPage gets loaded in a WriteableRaster and a
> given Colorspace.
> These get converted to a BufferedImage (with PDDeviceRGB.toRGBImage()). But
> the Type of the returing BufferedImage is with the given Raster and
> Colorspace always from Type "BufferedImage.TYPE_CUSTOM" instead of the
> expected "BufferedImage.TYPE_INT_RGB" for example.
> Consequences:
> Image-Processing-Operations with/on BufferedImages with TYPE_CUSTOM are not
> optimized in Java (slower) and partialy runs through "Synchronized" Blocks.
> ==> Converting different Documents in different Threads are blocking each
> other.
> "Quick"-Fix for seeing a Performance-Improvement in a Multithreading
> Environment:
> {code:title=PDDeviceRGB.java|borderStyle=solid}
> @Override
> public BufferedImage toRGBImage(WritableRaster raster) throws IOException {
> init();
> ColorModel colorModel = new ComponentColorModel(awtColorSpace, false,
> false, Transparency.OPAQUE,
> raster.getDataBuffer().getDataType());
> BufferedImage image = new BufferedImage(colorModel, raster, false,
> null);
> BufferedImage dest = new BufferedImage(image.getWidth(),
> image.getHeight(), BufferedImage.TYPE_INT_RGB);
> ColorConvertOp op = new
> ColorConvertOp(dest.getColorModel().getColorSpace(), null);
> return op.filter(image, dest);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
