[
https://issues.apache.org/jira/browse/PDFBOX-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374107#comment-16374107
]
Maruan Sahyoun commented on PDFBOX-4122:
----------------------------------------
In {{COSWriter}} we do not guard against {{null}} being passed to public and
protected methods but use a {{Hashtable}} so that {{null}} entries don't get
added. Unfortunately passing {{null}} will sometimes generate output sometimes
generate {{NPE}} within the methods or subsequent method calls where one is
flagged by Sonar but others may happen too.
Shouldn't we
- LOG.debug if null is being passed
- return wo doing something if {{null}} has been passed
- and replace {{Hashtable}} by {{HashMap}} as synchronization is not needed
AFAIU
> Resolve potential NPEs flagged by Sonar
> ---------------------------------------
>
> Key: PDFBOX-4122
> URL: https://issues.apache.org/jira/browse/PDFBOX-4122
> Project: PDFBox
> Issue Type: Sub-task
> Affects Versions: 3.0.0 PDFBox
> Reporter: Maruan Sahyoun
> Assignee: Maruan Sahyoun
> Priority: Major
> Fix For: 3.0.0 PDFBox
>
>
> We have many potential NPEs resolved by now but there are still some flagged
> by Sonar
> https://builds.apache.org/analysis/component_issues?id=org.apache.pdfbox%3Apdfbox-reactor#resolved=false|types=BUG|severities=BLOCKER.
> Although it's very unlikely that we hit them in practice e.g. as this would
> mean a very corrupt font file I'll try to resolve these debug logging the
> condition and returning in that case.
> [~tilman] [~lehmi] please comment/revert if you are not happy with the
> approach.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
