[
https://issues.apache.org/jira/browse/PDFBOX-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374919#comment-16374919
]
Tilman Hausherr commented on PDFBOX-4122:
-----------------------------------------
{quote}
- LOG.debug if null is being passed
- return wo doing something if null has been passed
- and replace Hashtable by HashMap as synchronization is not needed AFAIU
{quote}
Yes for the third one; I agree with checking for nulls when we read data, but
if we do this when writing data it means we would avoid crashing on our
programming errors. However my knowledge of COSWriter isn't very good.
> Resolve potential NPEs flagged by Sonar
> ---------------------------------------
>
> Key: PDFBOX-4122
> URL: https://issues.apache.org/jira/browse/PDFBOX-4122
> Project: PDFBox
> Issue Type: Sub-task
> Affects Versions: 3.0.0 PDFBox
> Reporter: Maruan Sahyoun
> Assignee: Maruan Sahyoun
> Priority: Major
> Fix For: 3.0.0 PDFBox
>
>
> We have many potential NPEs resolved by now but there are still some flagged
> by Sonar
> https://builds.apache.org/analysis/component_issues?id=org.apache.pdfbox%3Apdfbox-reactor#resolved=false|types=BUG|severities=BLOCKER.
> Although it's very unlikely that we hit them in practice e.g. as this would
> mean a very corrupt font file I'll try to resolve these debug logging the
> condition and returning in that case.
> [~tilman] [~lehmi] please comment/revert if you are not happy with the
> approach.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
