[ https://issues.apache.org/jira/browse/PDFBOX-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387674#comment-16387674 ]
Andreas Lehmkühler commented on PDFBOX-4122: -------------------------------------------- I'm fine with the first commit. With regard to the second commit we should throw an exception to avoid to create a malformed pdf if null is passed, but something more specific than a NPE > Resolve potential NPEs flagged by Sonar > --------------------------------------- > > Key: PDFBOX-4122 > URL: https://issues.apache.org/jira/browse/PDFBOX-4122 > Project: PDFBox > Issue Type: Sub-task > Affects Versions: 3.0.0 PDFBox > Reporter: Maruan Sahyoun > Assignee: Maruan Sahyoun > Priority: Major > Fix For: 3.0.0 PDFBox > > > We have many potential NPEs resolved by now but there are still some flagged > by Sonar > https://builds.apache.org/analysis/component_issues?id=org.apache.pdfbox%3Apdfbox-reactor#resolved=false|types=BUG|severities=BLOCKER. > Although it's very unlikely that we hit them in practice e.g. as this would > mean a very corrupt font file I'll try to resolve these debug logging the > condition and returning in that case. > [~tilman] [~lehmi] please comment/revert if you are not happy with the > approach. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org