[ 
https://issues.apache.org/jira/browse/PDFBOX-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803357#comment-16803357
 ] 

Tilman Hausherr commented on PDFBOX-4496:
-----------------------------------------

OK, I'm beginning to understand… this code
{code:java}
        PDDocument doc = PDDocument.load(new 
URL("https://issues.apache.org/jira/secure/attachment/12963758/original.pdf";).openStream());
        doc.getDocumentCatalog().getOCProperties().setGroupEnabled("de", false);
        doc.getDocumentCatalog().getOCProperties().setGroupEnabled("fi", true);
        BufferedImage bim = new PDFRenderer(doc).renderImage(0, 4);
        ImageIO.write(bim, "png", new File("huhu.png"));
 {code}
Should render the PDF with the French/Italian text and without the 
German/English text, but it doesn't, and your patch corrects this.

> OCG enablement with string parameter is not well defined
> --------------------------------------------------------
>
>                 Key: PDFBOX-4496
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4496
>             Project: PDFBox
>          Issue Type: Bug
>    Affects Versions: 2.0.14
>            Reporter: Stefan Ziel
>            Priority: Major
>              Labels: OCGs
>         Attachments: PDFBOX-4496.patch, original.pdf
>
>
> The class {noformat} 
> org.apache.pdfbox.pdmodel.graphics.optionalcontent.PDOptionalContentProperties
> {noformat}
> contains two methods
> {noformat} setGroupEnabled(String, boolean){noformat}  and {noformat} 
> isGroupEnabled(String){noformat} 
> accessing the OCG's state using a name as parameter.
> As there can exist various OCG with the same name this access is not well 
> defined. 
> The current implementation accesses the first group with this name it can 
> find.
> To make the setter work a solution would be a loop over all groups with the 
> given name and add them to ON or OFF. Consider to rename it to 
> {noformat}setGroupsEnabledByName{noformat}
> The getter should return some error state if the groups diverge in state - or 
> better drop it ...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to