[
https://issues.apache.org/jira/browse/PDFBOX-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260713#comment-17260713
]
Tilman Hausherr edited comment on PDFBOX-5067 at 1/7/21, 6:34 PM:
------------------------------------------------------------------
I looked at this and I don't get it - you load it into a local field "doc" and
then do nothing with that object. (The old code isn't much better because there
too, the file to be signed is opened twice) And while looking at this, I'm
wondering why the "setVisibleSignDesigner" methods are all public. It makes no
sense unless the author had bigger plans, e.g. passing a different file than
the one to sign.
was (Author: tilman):
I looked at this and I don't get it - you load it into a local field "doc" and
then do nothing with that one. (The old code isn't much better because in both
cases, the file to be signed is opened twice) And while looking at this, I'm
wondering why the "setVisibleSignDesigner" methods are all public. It makes no
sense unless the author had bigger plans, e.g. passing a different file than
the one to sign.
> make PDVisibleSignDesigner memory aware
> ---------------------------------------
>
> Key: PDFBOX-5067
> URL: https://issues.apache.org/jira/browse/PDFBOX-5067
> Project: PDFBox
> Issue Type: Improvement
> Components: Signing
> Affects Versions: 2.0.23
> Reporter: Ralf Hauser
> Priority: Major
> Attachments: patch5067_CreateVisibleSignature.txt,
> patch_PDFBOX-2512.txt, patch_PDFBOX-5067.txt
>
>
> PDFBOX-2512 might have failed earlier if I hadn't used
> MemoryUsageSetting.setupMixed(15000000)
> to limit the memory usage of PDDocument document to 15 MB in
> CreateVisibleSignature in
>
> a) setVisibleSignDesigner() and used the now memory-aware constructor of
> PDVisibleSignDesigner
> and
> b) in signPDF(), reused PDDocument
> setTsaUrl(tsaUrl);
> PDDocument doc = null;
> if (null != visibleSignDesigner) {
> doc = visibleSignDesigner.getDocument();
> }
> if (null == doc) {
> doc = Loader.loadPDF(inputFile, memoryUsageSetting);
> }
> // creating output document and prepare the IO streams.
> ...
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
