[
https://issues.apache.org/jira/browse/PDFBOX-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261281#comment-17261281
]
Tilman Hausherr edited comment on PDFBOX-5067 at 1/8/21, 12:38 PM:
-------------------------------------------------------------------
Done. I'm not really happy with it. It's kindof weird that the file parameter
is passed to sign() but is ignored if it was passed earlier.
I committed it anyway because it's an improvement that the file is opened only
once.
was (Author: tilman):
Done. I'm not really happy with it. It's kindof weird that the file parameter
is passed to sign() but is ignored if it was passed earlier.
> make PDVisibleSignDesigner memory aware
> ---------------------------------------
>
> Key: PDFBOX-5067
> URL: https://issues.apache.org/jira/browse/PDFBOX-5067
> Project: PDFBox
> Issue Type: Improvement
> Components: Signing
> Affects Versions: 2.0.23
> Reporter: Ralf Hauser
> Priority: Major
> Attachments: patch5067_CreateVisibleSignature.txt,
> patch_PDFBOX-2512.txt, patch_PDFBOX-5067.txt,
> patch_PDFBOX-5067_CreateVisibleSignature.a.txt,
> patch_PDFBOX-5067_CreateVisibleSignature.b.txt
>
>
> PDFBOX-2512 might have failed earlier if I hadn't used
> MemoryUsageSetting.setupMixed(15000000)
> to limit the memory usage of PDDocument document to 15 MB in
> CreateVisibleSignature in
>
> a) setVisibleSignDesigner() and used the now memory-aware constructor of
> PDVisibleSignDesigner
> and
> b) in signPDF(), reused PDDocument
> setTsaUrl(tsaUrl);
> PDDocument doc = null;
> if (null != visibleSignDesigner) {
> doc = visibleSignDesigner.getDocument();
> }
> if (null == doc) {
> doc = Loader.loadPDF(inputFile, memoryUsageSetting);
> }
> // creating output document and prepare the IO streams.
> ...
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
