valerybokov edited a comment on pull request #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-882028500
> This change makes code less readable and uses a boolean parameter which breaks the "do one thing" rule. (Yes we probably break this rule a lot, but there's no need to add more). It does save 3 or 4 bytes, but I doubt that this makes a difference. > https://twitter.com/unclebobmartin/status/1114137614377005057 Hi, @THausherr! I tried to allocate less memory. If you will purpose another way it will be good. I mean, if you will use public constructor (instead of private constructor and static method it will be simplier). As you see I got one second faster test results. About uncle Bob, yes but with constructor it will be a little complicated. To change parameters order to add constructor with will not clone an array is not good for this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
