valerybokov edited a comment on pull request #107: URL: https://github.com/apache/pdfbox/pull/107#issuecomment-907833215
Hi, @THausherr! My two observations. 1 Is it not too math to enlarge ScratchFileBuffer.pageIndexes array length twice (ScratchFileBuffer.addPage)? 2 PDVisibleSigBuilder.createTemplate. If this method will be called twice then previous template (PDDocument) not be closed. You able to store link to that template in a PDVisibleSigBuilder. If this link will be same as template field then it will be closed. 3 PDPageFitRectangleDestination. SetLeft method calls growToSize 3 to set index 2. This logic broken for methods setBottom and setRight. It looks like size should be different. PDPageXYZDestination.PDPageXYZDestination. The same problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
