lehmi commented on PR #270: URL: https://github.com/apache/pdfbox/pull/270#issuecomment-3342927550
The usage of the list in question is limited to TrueTypeEmbedder.subset(). It is one parameter for the constructor of TTFSubsetter, which itself is final and can't be extended. Looks like the list can be considered as constant, so that we might create a private static final instance using Arrays.asList or List.of Using a constant will avoid creating the list every time TrueTypeEmbedder.subset is called. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
