lehmi commented on PR #270: URL: https://github.com/apache/pdfbox/pull/270#issuecomment-3368896361
@THausherr you've committed 2 different implementations. I guess due to the fact that List.of isn't available in java versions < 9. Maybe Arrays.asList is the better solution as it is available in all relevant java version. AFAIK there is just one difference Array.asList creates a mutable list. However, none of the solutions uses a constant. The list is still created every time the method is called -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org