acelyc111 commented on a change in pull request #592:
URL: https://github.com/apache/incubator-pegasus/pull/592#discussion_r480063507
##########
File path: src/server/hotspot_algo_qps_variance.h
##########
@@ -0,0 +1,30 @@
+// Copyright (c) 2017, Xiaomi, Inc. All rights reserved.
+// This source code is licensed under the Apache License Version 2.0, which
+// can be found in the LICENSE file in the root directory of this source tree.
+
+#pragma once
+
+#include <algorithm>
+#include <gtest/gtest_prod.h>
+#include <math.h>
+
+#include "hotspot_partition_data.h"
+#include "table_hotspot_policy.h"
+#include <dsn/perf_counter/perf_counter.h>
+
+namespace pegasus {
+namespace server {
+// PauTa Criterion
+class hotspot_algo_qps_variance : public hotspot_policy
Review comment:
There is no other class inherit from hotspot_policy, why not combine the
two classes?
##########
File path: src/server/hotspot_algo_qps_variance.cpp
##########
@@ -0,0 +1,60 @@
+// Copyright (c) 2017, Xiaomi, Inc. All rights reserved.
Review comment:
Use Apache standard license
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
