hycdong commented on a change in pull request #592:
URL: https://github.com/apache/incubator-pegasus/pull/592#discussion_r486786586
##########
File path: src/server/hotspot_partition_calculator.h
##########
@@ -24,6 +24,9 @@
namespace pegasus {
namespace server {
+typedef std::list<std::vector<hotspot_partition_data>> statistical_histories;
+typedef std::vector<std::vector<std::unique_ptr<dsn::perf_counter_wrapper>>>
hot_partition_counters;
Review comment:
`std::vector<std::vector<......>>> hot_partition_counters`, This
sturcture is a little bit complex, could you please explain why you design it
like that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
