levy5307 commented on a change in pull request #597:
URL: https://github.com/apache/incubator-pegasus/pull/597#discussion_r484804533
##########
File path: src/server/info_collector.h
##########
@@ -177,15 +177,16 @@ class info_collector
uint32_t _storage_size_fetch_interval_seconds;
uint32_t _storage_size_retry_wait_seconds;
uint32_t _storage_size_retry_max_count;
- std::string _hotspot_detect_algorithm;
::dsn::task_ptr _storage_size_stat_timer_task;
::dsn::utils::ex_lock_nr _capacity_unit_update_info_lock;
// mapping 'node address' --> 'last updated timestamp'
std::map<std::string, string> _capacity_unit_update_info;
- std::map<std::string, hotspot_calculator *> _hotspot_calculator_store;
-
- hotspot_calculator *get_hotspot_calculator(const std::string &app_name,
- const int partition_num);
+ // _hotspot_calculator_store is to save hotspot_partition_calculator for
each table, a
+ // hotspot_partition_calculator saves historical hotspot data and alert
perf_counters of
+ // corresponding table
+ std::map<std::string, std::shared_ptr<hotspot_partition_calculator>>
_hotspot_calculator_store;
Review comment:
Why didn't you use `std::unique_ptr` instead of `std::shared_ptr`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
