acelyc111 commented on a change in pull request #597:
URL: https://github.com/apache/incubator-pegasus/pull/597#discussion_r484806342
##########
File path: src/server/info_collector.cpp
##########
@@ -302,25 +291,16 @@ void info_collector::on_storage_size_stat(int
remaining_retry_count)
_result_writer->set_result(st_stat.timestamp, "ss",
st_stat.dump_to_json());
}
-hotspot_calculator *info_collector::get_hotspot_calculator(const std::string
&app_name,
- const int
partition_num)
+std::shared_ptr<hotspot_partition_calculator>
+info_collector::get_hotspot_calculator(const std::string &app_name, const int
partition_count)
{
- // use appname+partition_num as a key can prevent the impact of dynamic
partition changes
- std::string app_name_pcount = fmt::format("{}.{}", app_name,
partition_num);
+ // use appname+partition_count as a key can prevent the impact of dynamic
partition changes
Review comment:
```suggestion
// use app_name+partition_count as a key can prevent the impact of
dynamic partition changes
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
