hycdong commented on a change in pull request #592:
URL: https://github.com/apache/incubator-pegasus/pull/592#discussion_r486825140
##########
File path: src/server/hotspot_partition_calculator.h
##########
@@ -24,6 +24,9 @@
namespace pegasus {
namespace server {
+typedef std::list<std::vector<hotspot_partition_data>> statistical_histories;
+typedef std::vector<std::vector<std::unique_ptr<dsn::perf_counter_wrapper>>>
hot_partition_counters;
Review comment:
Well, I still think it is complex to read. How about seperate read and
write? If there will only have read and write needing to calculate hotspot
value, like below:
```
typedef std::vector<std::unique_ptr<dsn::perf_counter_wrapper>>
hot_partition_counters;
hot_partition_counters _read_hot_points;
hot_partition_counters _write_hot_points;
```
Besides, could you please also explain `statistical_histories` meaning? It
is also complex.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
