empiredan commented on a change in pull request #646:
URL: https://github.com/apache/incubator-pegasus/pull/646#discussion_r539808859
##########
File path: src/server/pegasus_server_impl_init.cpp
##########
@@ -299,6 +300,128 @@
pegasus_server_impl::pegasus_server_impl(dsn::replication::replica *r)
_db_opts.rate_limiter = _s_rate_limiter;
}
+ bool enable_write_buffer_manager =
+ dsn_config_get_value_bool("pegasus.server",
+ "rocksdb_enable_write_buffer_manager",
+ false,
+ "enable write buffer manager to limit total
memory "
+ "used by memtables and block caches across
multiple replicas");
+ ddebug("rocksdb_enable_write_buffer_manager = %d",
enable_write_buffer_manager);
+ if (enable_write_buffer_manager) {
+ // If write buffer manager is enabled, all replicas(one DB instance
for each
+ // replica) on this server will share the same write buffer manager
object,
+ // thus the same block cache object. It's convenient to control the
total memory
+ // of memtables and block caches used by this server
+ static std::once_flag flag;
+ std::call_once(flag, [&]() {
+ int64_t total_size_across_write_buffer =
dsn_config_get_value_int64(
+ "pegasus.server",
+ "rocksdb_total_size_across_write_buffer",
+ 0,
+ "total size limit used by memtables across multiple replicas");
+ ddebug("rocksdb_total_size_across_write_buffer = %" PRId64,
+ total_size_across_write_buffer);
+ if (total_size_across_write_buffer < 0) {
+ total_size_across_write_buffer = 0;
+ }
+ _s_write_buffer_manager =
std::make_shared<rocksdb::WriteBufferManager>(
+ static_cast<size_t>(total_size_across_write_buffer),
tbl_opts.block_cache);
+ });
+ _db_opts.write_buffer_manager = _s_write_buffer_manager;
+ }
+
+ int64_t max_open_files = dsn_config_get_value_int64(
Review comment:
Actually max_open_files is defined as int type in
include/rocksdb/options.h, and -1 means files opened are always kept open. So
here it has to be signed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
