empiredan commented on a change in pull request #646:
URL: https://github.com/apache/incubator-pegasus/pull/646#discussion_r539810835
##########
File path: src/server/pegasus_server_impl.cpp
##########
@@ -68,6 +68,7 @@ static bool chkpt_init_from_dir(const char *name, int64_t
&decree)
std::shared_ptr<rocksdb::RateLimiter> pegasus_server_impl::_s_rate_limiter;
int64_t pegasus_server_impl::_rocksdb_limiter_last_total_through;
std::shared_ptr<rocksdb::Cache> pegasus_server_impl::_s_block_cache;
+std::shared_ptr<rocksdb::WriteBufferManager>
pegasus_server_impl::_s_write_buffer_manager;
Review comment:
In include/rocksdb/options.h, it is defined as
std::shared_ptr<WriteBufferManager> as a member of rocksdb::DBOptions, so we'd
better keep shared_ptr here ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
