foreverneverer commented on code in PR #1065:
URL: https://github.com/apache/incubator-pegasus/pull/1065#discussion_r924124025
##########
src/rdsn/src/meta/server_state.h:
##########
@@ -353,6 +353,41 @@ class server_state
const
std::vector<std::string> &keys,
const
std::vector<std::string> &values);
+ bool app_info_compatible_equal(const app_info &l, const app_info &r) const
+ {
+ if (l.status != r.status) {
+ return false;
+ }
+ if (l.app_type != r.app_type) {
+ return false;
+ }
+ if (l.app_name != r.app_name) {
+ return false;
+ }
+ if (l.app_id != r.app_id) {
+ return false;
+ }
+ if (l.partition_count != r.partition_count) {
+ return false;
+ }
+ if (l.is_stateful != r.is_stateful) {
+ return false;
+ }
+ if (l.max_replica_count != r.max_replica_count) {
+ return false;
+ }
+ if (l.expire_second != r.expire_second) {
+ return false;
+ }
+ if (l.create_second != r.create_second) {
+ return false;
+ }
+ if (l.drop_second != r.drop_second) {
+ return false;
+ }
Review Comment:
```suggestion
if (l.status != r.status || l.app_type != r.app_type || ... || ...
...) {
return false;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
