acelyc111 commented on PR #1065:
URL:
https://github.com/apache/incubator-pegasus/pull/1065#issuecomment-1189939391
I found before `duplicating` field is, before:
```
12:optional bool duplicating;
```
after:
```
12:optional bool duplicating = false;
```
Because it's `optional`, the `operator ==` of `app_info` will check whether
this filed is set or not at first, like:
```
if (__isset.duplicating != rhs.__isset.duplicating)
return false;
else if (__isset.duplicating && !(duplicating == rhs.duplicating))
return false;
```
That is to say, if `duplicating` is not set, the default value will not take
effect, so how this bug happend?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
