[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1150: feat(backup): 9. replica handle backup clear context and invalid status

Tue, 20 Sep 2022 23:38:25 -0700 


acelyc111 commented on code in PR #1150:
URL: https://github.com/apache/incubator-pegasus/pull/1150#discussion_r976089172


##########
src/rdsn/src/common/backup_restore_common.h:
##########
@@ -29,6 +29,7 @@ namespace dsn {
 namespace replication {
 
 DSN_DECLARE_string(cold_backup_root);
+DSN_DECLARE_uint32(cold_backup_checkpoint_reserve_minutes);

Review Comment:
   If I disn't miss anything, ther are only 2 files use it, delare it in thw 2 
files will cause any problem?



##########
docker/README.md:
##########
@@ -27,7 +27,7 @@ to deploying a standalone cluster of Pegasus containers on 
your local machine.
 
 [![BuildThirdpartyDockerRegularly - build and publish thirdparty every 
week](https://github.com/apache/incubator-pegasus/actions/workflows/thirdparty-regular-push.yml/badge.svg)](https://github.com/apache/incubator-pegasus/actions/workflows/thirdparty-regular-push.yml)
 
-[![BuildPegasusRegularly - build pegasus and rdsn on different env every 
day](https://github.com/apache/incubator-pegasus/actions/workflows/pegasus-regular-build.yml/badge.svg)](https://github.com/apache/incubator-pegasus/actions/workflows/pegasus-regular-build.yml)
+[![BuildPegasusRegularly - build pegasus and rdsn on different env every 
day](https://github.com/apache/incubator-pegasus/actions/workflows/regular-build.yml/badge.svg)](https://github.com/apache/incubator-pegasus/actions/workflows/regular-build.yml)

Review Comment:
   I missed that this is on a develop branch, ignore that.



##########
src/rdsn/src/common/backup_restore_common.h:
##########
@@ -29,6 +29,7 @@ namespace dsn {
 namespace replication {
 
 DSN_DECLARE_string(cold_backup_root);
+DSN_DECLARE_uint32(cold_backup_checkpoint_reserve_minutes);

Review Comment:
   If I didn't miss anything, ther are only 2 files use it, delare it in thw 2 
files will cause any problem?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to