acelyc111 commented on code in PR #1150:
URL: https://github.com/apache/incubator-pegasus/pull/1150#discussion_r976213538
##########
src/rdsn/src/common/backup_restore_common.h:
##########
@@ -29,6 +29,7 @@ namespace dsn {
namespace replication {
DSN_DECLARE_string(cold_backup_root);
+DSN_DECLARE_uint32(cold_backup_checkpoint_reserve_minutes);
Review Comment:
I think it's a type of combine rule of Include_What_You_Use and
Forward_Declarations. If the header file dose use the header/type itself, avoid
including / declearing it in header files, include or declear it in the place
where really use it.
1. https://google.github.io/styleguide/cppguide.html#Include_What_You_Use
2. https://google.github.io/styleguide/cppguide.html#Forward_Declarations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
