levy5307 commented on code in PR #1192: URL: https://github.com/apache/incubator-pegasus/pull/1192#discussion_r1000401709
########## src/rdsn/src/utils/metrics.h: ########## @@ -389,53 +389,55 @@ template <typename T, typename = typename std::enable_if<std::is_arithmetic<T>:: class gauge : public metric Review Comment: Why didn't you change `typename T` to `typename value_type` in the above line? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org For additional commands, e-mail: dev-h...@pegasus.apache.org
