empiredan commented on code in PR #1192: URL: https://github.com/apache/incubator-pegasus/pull/1192#discussion_r1000450129
########## src/rdsn/src/utils/metrics.h: ########## @@ -389,53 +389,55 @@ template <typename T, typename = typename std::enable_if<std::is_arithmetic<T>:: class gauge : public metric Review Comment: > Why didn't you change `typename T` to `typename value_type` in the above line? `value_type` may be a combination of multiple template parameters. For example, in std::map, `value_type` is defined as `std::pair<const _Key, _Tp>`. Thus customarily `value_type` is used to decouple from template parameters though for `gauge` it is just the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
